Welcome to Dream.In.Code
Become a C++ Expert!

Join 149,934 C++ Programmers for FREE! Get instant access to thousands of C++ experts, tutorials, code snippets, and more! There are 1,533 people online right now. Registration is fast and FREE... Join Now!




I need Your Reveiw

 
Reply to this topicStart new topic

I need Your Reveiw, This is my First Project I need your review through your comments

rockey
31 Jan, 2008 - 06:47 AM
Post #1

D.I.C Head
**

Joined: 2 Jan, 2008
Posts: 57


My Contributions
Animated House Program. This is My first project which I completed this yesterday. So now I want your review about my project. Its a simple Graphical home program. So Download this project in text document and pass your comments about that.

Thanks

Regards:
Rockey


Attached File(s)
Attached File  House_Project.txt ( 14.45k ) Number of downloads: 33
User is offlineProfile CardPM
+Quote Post

PennyBoki
RE: I Need Your Reveiw
1 Feb, 2008 - 04:20 PM
Post #2

system("revolution");
Group Icon

Joined: 11 Dec, 2006
Posts: 2,011



Thanked: 7 times
Dream Kudos: 500
Expert In: Java,C++,C

My Contributions
You know you will probably get more responses if you post the code like this code.gif rather than uploading it as a file. Just a hint.

This post has been edited by PennyBoki: 1 Feb, 2008 - 04:22 PM
User is offlineProfile CardPM
+Quote Post

pertheusual
RE: I Need Your Reveiw
1 Feb, 2008 - 07:23 PM
Post #3

D.I.C Head
**

Joined: 26 Jan, 2008
Posts: 233



Thanked: 4 times
My Contributions
just looked over the code quickly. My only big comment would be that it is just about impossible to read.

Your comments are helpful and make understanding much easier, but they also make the code even longer. I would really recommend that you move your code into separate methods, REALLY.

Rather than having comments followed by code, have descriptive method names and put the code and comments in the methods.

It is much easier to understand something like:
CODE

int main(){
     drawMoon();
     drawRightWall();
     drawLeftWall();
     checkInput();
     ...
     and so on
}


Also, the part where your get user input should probably print out a list of menu commands. ( unless I missed that somewhere)
And your if statements can be else if's or switch statements. Might make understanding a little easier.

I can't really comment on the Graphics part. Never coded with that API. I like the moon though. There HAS to be a way to draw a filled circle. It kinda made me laugh though!

Per
User is offlineProfile CardPM
+Quote Post

Reply to this topicStart new topic
Time is now: 1/8/09 03:54PM

Be Social

Dream.In.Code RSS Feed Dream.In.Code LinkedIn Group Follow Us On Twitter

Live C++ Help!

C++ Tutorials

Reference Sheets

C++ Snippets

DIC Chatroom

Bye Bye Ads

Monthly Drawing

Thumb Drive

Top Contributors

Top 10 Kudos This Month